Limit GetSimilarRecordsList by index. #1082
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing as part of repository maintenance - no further action planned on this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context (Why the change? What's the scenario?)
For SQL Server 2025, the PrepareGetSimilarRecordsListQuery() method produces a query that does not account for the index that is being searched. This only happens when NativeVectorSearch is true and the VectorQueryProvider is used. The DefaultQueryProvider does not suffer from the same problem (though may benefit from the same fix performance-wise) because it links to tables that are index-specific, like [{embeddingstable}_{index}] which naturally limits the memories via the inner join.
High level description (Approach, Design)
Simply add in the [collection]=@index criteria.